[
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=741866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-741866
]
ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/22 21:07
Start Date: 15/Mar/22 21:07
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #17064:
URL: https://github.com/apache/beam/pull/17064#discussion_r827416400
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/ChangeStreamMetrics.java
##########
@@ -84,6 +88,25 @@
public static final Counter DATA_RECORD_COUNT =
Metrics.counter(ChangeStreamMetrics.class, "data_record_count");
+ /** Counter for the total number of queries issued during the execution of
the Connector. */
+ public static final Counter QUERY_COUNT =
+ Metrics.counter(ChangeStreamMetrics.class, "query_count");
+
+ /** Counter for record latencies [0, 1000) ms during the execution of the
Connector. */
+ public static final Counter
DATA_RECORD_COMMITTED_TO_EMITTED_0MS_TO_1000MS_COUNT =
+ Metrics.counter(
+ ChangeStreamMetrics.class,
"data_record_committed_to_emitted_0ms_to_1000ms_count");
+
+ /** Counter for record latencies [1000, 3000) ms during the execution of the
Connector. */
+ public static final Counter
DATA_RECORD_COMMITTED_TO_EMITTED_1000MS_TO_3000MS_COUNT =
+ Metrics.counter(
+ ChangeStreamMetrics.class,
"data_record_committed_to_emitted_1000ms_to_3000ms_count");
+
+ /** Counter for record latencies equal or above 3000ms during the execution
of the Connector. */
+ public static final Counter
DATA_RECORD_COMMITTED_TO_EMITTED_3000MS_TO_INF_COUNT =
+ Metrics.counter(
+ ChangeStreamMetrics.class,
"data_record_committed_to_emitted_3000ms_to_inf_count");
Review comment:
we also have a `Metrics.distribution` that you can use for cases like
these. Did you consider it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 741866)
Time Spent: 49.5h (was: 49h 20m)
> SpannerIO Change Stream Connector
> ---------------------------------
>
> Key: BEAM-12164
> URL: https://issues.apache.org/jira/browse/BEAM-12164
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Thiago Nunes
> Assignee: Thiago Nunes
> Priority: P2
> Fix For: 2.37.0
>
> Time Spent: 49.5h
> Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
> with the support for Spanner Change Streams (CDC). CDC support is just being
> implemented in Spanner and it will be exposed through a gRPC API. We will use
> such API to create a new SpannerIO.readChangeStream(...) implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
