[
https://issues.apache.org/jira/browse/BEAM-13880?focusedWorklogId=744031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744031
]
ASF GitHub Bot logged work on BEAM-13880:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/22 14:58
Start Date: 18/Mar/22 14:58
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r829122590
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -76,18 +112,18 @@ func TestValidator(t *testing.T) {
// As a result, want to receive an expected validator
builder.
name: "Test correct validator builder",
args: args{
- paths: paths,
- sdkEnv: sdkEnv,
+ paths: pythonPaths,
+ sdkEnv: pythonSdkEnv,
Review comment:
Should we do the same for Java, Go and SCIO SDKs?
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -143,16 +179,16 @@ func TestPreparer(t *testing.T) {
{
// Test case with calling Setup with incorrect SDK.
// As a result, want to receive an error.
- name: "incorrect sdk",
- args: args{*paths, pipelineOptions, wrongSdkEnv,
&validationResults},
+ name: "Incorrect sdk",
+ args: args{*pythonPaths, pipelineOptions,
wrongSdkEnv, &validationResults},
want: nil,
wantErr: true,
},
{
// Test case with calling Setup with correct SDK.
// As a result, want to receive an expected preparer
builder.
- name: "correct sdk",
- args: args{*paths, pipelineOptions, sdkEnv,
&validationResults},
+ name: "Correct sdk",
+ args: args{*pythonPaths, pipelineOptions,
pythonSdkEnv, &validationResults},
Review comment:
ditto
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -195,10 +231,10 @@ func TestCompiler(t *testing.T) {
{
// Test case with calling Setup with correct data.
// As a result, want to receive an expected compiler
builder.
- name: "Test correct compiler builder",
+ name: "Test correct compiler builder with java sdk",
Review comment:
Should we do the same test for Go and SCIO?
##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -271,27 +403,49 @@ func TestTestRunner(t *testing.T) {
want *executors.ExecutorBuilder
}{
{
- // Test case with calling Setup with correct data.
- // As a result, want to receive an expected test
builder.
- name: "Test correct test builder",
+ name: "Test correct run builder with Java sdk",
Review comment:
Shouldn't we also have the same test cases for Python SDK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744031)
Time Spent: 50m (was: 40m)
> [Playground] Increase test coverage for the setup_tools package
> ---------------------------------------------------------------
>
> Key: BEAM-13880
> URL: https://issues.apache.org/jira/browse/BEAM-13880
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Pavel Avilov
> Priority: P2
> Labels: beam-playground-backend
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Need to add unit tests to increase test coverage for the _setup_tools_
> package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
