[
https://issues.apache.org/jira/browse/BEAM-10976?focusedWorklogId=744420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744420
]
ASF GitHub Bot logged work on BEAM-10976:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/22 20:53
Start Date: 18/Mar/22 20:53
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #17045:
URL: https://github.com/apache/beam/pull/17045#issuecomment-1072787921
> > do you know why there is a large drop in code coverage diff?
>
> @aaltay I think its because out of 306 non-test lines changed, 188 are
generated file changes. In particular, `reflectx/calls.go` is going from 0%
coverage to 0% coverage, but its contributing 164 new untested lines. So unless
I manually test the generated files (and I'd argue we should be testing the
generation logic instead), the diff is guaranteed to drop. Looking at the
per-file diff, I don't feel particularly bad about any of the changes.
I agree with you.
I guess it would make sense to not count generated files toward code
coverage. (Neither a high priority, nor a blocker for this PR.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744420)
Time Spent: 9h 40m (was: 9.5h)
> Enable Bundle Finalization in Go SDK
> ------------------------------------
>
> Key: BEAM-10976
> URL: https://issues.apache.org/jira/browse/BEAM-10976
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Danny McCormick
> Priority: P3
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Eg. to support acking pubsub/kafka messages as processed after the results
> have been properly committed by the runner.
> Note, that due to BEAM-10959 that when implementing this, an instruction must
> remain "active" until it's finalization occurs as well. Specifically, we
> should probably keep another map around for "to be finalized" process bundle
> instructions so we can return the appropriate "empty" response and not
> accidently evict them from the nearly equivalent inactive state until after
> finalization.
> [https://s.apache.org/beam-finalizing-bundles]
>
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
> See also Java and Python approaches
> https://beam.apache.org/documentation/programming-guide/#bundle-finalization
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
