[
https://issues.apache.org/jira/browse/BEAM-14116?focusedWorklogId=744464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744464
]
ASF GitHub Bot logged work on BEAM-14116:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/22 22:32
Start Date: 18/Mar/22 22:32
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on a change in pull request
#17094:
URL: https://github.com/apache/beam/pull/17094#discussion_r830388174
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -56,13 +58,13 @@ private MonitoringInfoMetricName(String urn, Map<String,
String> labels) {
public String getNamespace() {
if (labels.containsKey(MonitoringInfoConstants.Labels.NAMESPACE)) {
Review comment:
Done.
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -33,9 +33,6 @@
* key instead of only a name+namespace. This is useful when defining system
defined metrics with a
* specific urn via a {@code CounterContainer}.
*/
-@SuppressWarnings({
- "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
-})
public class MonitoringInfoMetricName extends MetricName {
private String urn;
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744464)
Time Spent: 2.5h (was: 2h 20m)
> Fix Pub/Sub Lite IO and SDF performance issues with shuffles
> ------------------------------------------------------------
>
> Key: BEAM-14116
> URL: https://issues.apache.org/jira/browse/BEAM-14116
> Project: Beam
> Issue Type: Task
> Components: io-java-gcp, runner-dataflow
> Reporter: Daniel Collins
> Assignee: Daniel Collins
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
