[
https://issues.apache.org/jira/browse/BEAM-13939?focusedWorklogId=744483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744483
]
ASF GitHub Bot logged work on BEAM-13939:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/22 23:27
Start Date: 18/Mar/22 23:27
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #16961:
URL: https://github.com/apache/beam/pull/16961#issuecomment-1072885334
> > Why are we losing the license header on the generated GRPC pb.go files,
but not the standard pb.go files? Not really an issue, since we can ignore it
in the RAT check, but it is strange.
>
> TBH I don't know (sad). I saw that and spent some time loosely
investigating. I agree that ideally we would have the license header, so I am
happy to find some fix before merging! If you have tips on direction or if your
google-foo is good, would love any help 🙏🏽
It's most likely an artifact from when you were experiementing and getting
things aligned properly. There's nothing that inserts the header into the
files, so it should be maintaining the headers through regeneration.
At this point, I'd suggest simply re-adding the header texts manually to
start, and commit that. Then we can try a re-gen with your scripts, changing
nothing else. If they don't get stripped from that process, we know it was an
accident as the scripts were being worked on.
If they do get stripped, we could also just use the scripts to ensure the
header is prefixed onto all the generated Go files. There's a go tool that can
do this: https://github.com/google/addlicense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744483)
Time Spent: 18h 20m (was: 18h 10m)
> Go SDK: Protobuf namespace conflict
> -----------------------------------
>
> Key: BEAM-13939
> URL: https://issues.apache.org/jira/browse/BEAM-13939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go
> Affects Versions: 2.36.0
> Reporter: Milan Patel
> Priority: P2
> Attachments: demobug.zip
>
> Time Spent: 18h 20m
> Remaining Estimate: 0h
>
> The Go SDK generated grpc protobufs are not namespaced with enough
> granularity. If a user has another external dependency with the same protobuf
> file registered with the proto runtime, their compiled binary will panic at
> runtime pointing the user to this [doc
> page|https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict].
>
> In the interim, following the instructions to add either ldflags to the
> compiler or an environment var to the binary works, but this is an unideal
> solution since only one of the duplicate proto specifications will be
> accessible from a [global
> registry|https://pkg.go.dev/google.golang.org/[email protected]/reflect/protoregistry].
>
> Ask: Regenerate the go protos such that descriptors like
> [these|https://github.com/apache/beam/blob/84353a7c973d3acaaa56d81c265dce7193a56be5/sdks/go/pkg/beam/model/pipeline_v1/metrics.pb.go#L797-L811]
> are outputted with filenames that are more granular, such as a filename that
> includes the directory structure of the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
