[
https://issues.apache.org/jira/browse/BEAM-6695?focusedWorklogId=225349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225349
]
ASF GitHub Bot logged work on BEAM-6695:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/19 00:03
Start Date: 10/Apr/19 00:03
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #8206: [BEAM-6695]
Latest PTransform for Python SDK
URL: https://github.com/apache/beam/pull/8206#discussion_r273748642
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -45,6 +45,7 @@
from apache_beam.typehints import Union
from apache_beam.typehints import with_input_types
from apache_beam.typehints import with_output_types
+from apache_beam.typehints.decorators import _check_instance_type
Review comment:
`with_input_types` won't work here. Are there other public functions that
does the check available? I still believe importing private functions is not a
good approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 225349)
Time Spent: 5h 10m (was: 5h)
> Latest transform for Python SDK
> -------------------------------
>
> Key: BEAM-6695
> URL: https://issues.apache.org/jira/browse/BEAM-6695
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Tanay Tummalapalli
> Priority: Minor
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Add a PTransform} and Combine.CombineFn for computing the latest element in a
> PCollection.
> It should offer the same API as its Java counterpart:
> https://github.com/apache/beam/blob/11a977b8b26eff2274d706541127c19dc93131a2/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Latest.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
