[
https://issues.apache.org/jira/browse/BEAM-7042?focusedWorklogId=225608&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225608
]
ASF GitHub Bot logged work on BEAM-7042:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/19 14:04
Start Date: 10/Apr/19 14:04
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #8268: [BEAM-7042] remove
antlr from shadow configuration
URL: https://github.com/apache/beam/pull/8268#issuecomment-481704888
If you move it into the generateFromSource task, it still leaks I triied
this way but I have a really low level of gradle-fu so maybe there is a way to
remove it afterwards.
```diff
diff --git a/sdks/java/core/build.gradle b/sdks/java/core/build.gradle
index a4a1264922..f271733284 100644
--- a/sdks/java/core/build.gradle
+++ b/sdks/java/core/build.gradle
@@ -34,6 +34,7 @@ applyAvroNature()
applyAntlrNature()
generateGrammarSource {
+ dependencies { antlr library.java.antlr }
arguments += ["-visitor"]
}
@@ -58,7 +59,6 @@ test {
}
dependencies {
- antlr library.java.antlr
// Required to load constants from the model, e.g. max timestamp for
global window
shadow project(path: ":beam-model-pipeline", configuration: "shadow")
shadow project(path: ":beam-model-job-management", configuration:
"shadow")
@@ -69,7 +69,6 @@ dependencies {
compile library.java.commons_compress
compile library.java.commons_lang3
compile library.java.guava_testlib
- shadow library.java.antlr
shadow library.java.jackson_core
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 225608)
Time Spent: 0.5h (was: 20m)
> [regression] org.apache.beam:beam-sdks-java-core:jar:2.12.0 dependencies are
> way fatter and conflicting than before
> -------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-7042
> URL: https://issues.apache.org/jira/browse/BEAM-7042
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Reuven Lax
> Priority: Major
> Fix For: 2.13.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hi guys,
> seems current sdk brings antlr and its transitive deps which is quite
> unlikely and has a huge probability to conflict (antlt, jsonp in an outdated
> version at least for the one breaking my apps)
> can it be cleaned up for the 2.12 to avoid to break application please?
> Thanks,
> Romain
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
