[
https://issues.apache.org/jira/browse/BEAM-14144?focusedWorklogId=745980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745980
]
ASF GitHub Bot logged work on BEAM-14144:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/22 17:51
Start Date: 22/Mar/22 17:51
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #17151:
URL: https://github.com/apache/beam/pull/17151#discussion_r832452714
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java
##########
@@ -216,6 +216,25 @@ public Dataflow create(PipelineOptions options) {
void setDumpHeapOnOOM(boolean dumpHeapBeforeExit);
+ /**
+ * If true, save a JFR profile when GC thrashing is first detected. The
profile will run for the
+ * amount of time set by --jfrRecordingDurationSec, or 60 seconds by default.
+ *
+ * <p>Note, JFR profiles are only supported on java 9 and up.
+ */
+ @Description(
+ "If true, save a JFR profile before killing a thread or process "
+ + "which is GC thrashing or out of memory. Only available on java 9
or up")
+ boolean getRecordJfrOnGcThrashing();
Review comment:
This feature is nice, can we add it to sdks/java/harness as well so all
portable runners can get it instead of just Dataflow?
See
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java
and
https://github.com/apache/beam/blob/master/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/status/MemoryMonitor.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 745980)
Time Spent: 40m (was: 0.5h)
> Record JFR profiles when GC thrashing is detected
> -------------------------------------------------
>
> Key: BEAM-14144
> URL: https://issues.apache.org/jira/browse/BEAM-14144
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It'd be useful for debugging GC issues in jobs to have allocation profiles
> when it was occurring. In java 9+, JFR is included in the JDK, we could use
> that to record profiles when GC thrashing is detected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
