[
https://issues.apache.org/jira/browse/BEAM-13695?focusedWorklogId=746109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746109
]
ASF GitHub Bot logged work on BEAM-13695:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/22 20:31
Start Date: 22/Mar/22 20:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #17110:
URL: https://github.com/apache/beam/pull/17110#discussion_r832596779
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
##########
@@ -217,4 +217,22 @@ public String create(PipelineOptions options) {
boolean isHotKeyLoggingEnabled();
void setHotKeyLoggingEnabled(boolean value);
+
+ /**
+ * Open modules needed for reflection that access JDK internals with Java 17+
Review comment:
```suggestion
* Open modules needed for reflection that access JDK internals with Java
9+
```
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java
##########
@@ -294,4 +295,18 @@ public static SdkHarnessLogLevelOverrides from(Map<String,
String> values) {
return overrides;
}
}
+
+ /**
+ * Open modules needed for reflection that access JDK internals with Java 17+
Review comment:
```suggestion
* Open modules needed for reflection that access JDK internals with Java
9+
```
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java
##########
@@ -294,4 +295,18 @@ public static SdkHarnessLogLevelOverrides from(Map<String,
String> values) {
return overrides;
}
}
+
+ /**
+ * Open modules needed for reflection that access JDK internals with Java 17+
+ *
+ * <p>With JDK 16+, <a href="#{https://openjdk.java.net/jeps/403}";>JDK
internals are strongly
+ * encapsulated</a> and can result in an InaccessibleObjectException being
thrown if a tool or
+ * library uses reflection that access JDK internals. If you see these
errors in your worker logs,
+ * you can pass in modules to open using the format
module/package=target-module(,target-module)*
+ * to allow access to the library. E.g. java.base/java.lang=jamm
+ */
Review comment:
```suggestion
*
* <p>You may see warnings that jamm, a library used to more accurately
size objects, is unable to
* make a private field accessible. To resolve the warning, open the
specified module/package to
* jamm.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 746109)
Time Spent: 1h 20m (was: 1h 10m)
> Provide more accurate size estimates for cache objects in Java 17
> -----------------------------------------------------------------
>
> Key: BEAM-13695
> URL: https://issues.apache.org/jira/browse/BEAM-13695
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Kiley Sok
> Priority: P2
> Fix For: 2.38.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
