[
https://issues.apache.org/jira/browse/BEAM-13416?focusedWorklogId=746688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746688
]
ASF GitHub Bot logged work on BEAM-13416:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/22 16:45
Start Date: 23/Mar/22 16:45
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16947:
URL: https://github.com/apache/beam/pull/16947#discussion_r833461932
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sns/SnsResponseCoder.java
##########
@@ -30,7 +30,12 @@
import org.apache.beam.sdk.coders.VarIntCoder;
import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList;
-/** Custom Coder for WrappedSnsResponse. */
+/**
+ * Custom Coder for WrappedSnsResponse.
+ *
+ * @deprecated Coder of deprecated {@link SnsResponse}.
Review comment:
What is the deprecation plan? Should users be opting in to using the
SchemaCoder based approach, or are we keeping these coders here so that they
can opt-out of schemas and use these instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 746688)
Time Spent: 2h 50m (was: 2h 40m)
> SqsIO.write input / construction of Sqs request
> -----------------------------------------------
>
> Key: BEAM-13416
> URL: https://issues.apache.org/jira/browse/BEAM-13416
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: Moritz Mack
> Priority: P2
> Labels: aws, aws-sdk-v2, sqs
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> SqsIO.write should support arbitrary types T and be implemented in terms of a
> mapper function that converts T into an AWS request.
> The current implementation of write as
> {{PTransform<PCollection<SendMessageRequest>, PDone>}} is a rather poor
> choice. It may requires an additional unnecessary serialization &
> deserialisation round. But even worse, the current
> {{SendMessageRequestCoder}} does not support any advanced configuration
> beyond queueUrl and messageBody and will silently drop it without even
> warning the user.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
