[
https://issues.apache.org/jira/browse/BEAM-3607?focusedWorklogId=748067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748067
]
ASF GitHub Bot logged work on BEAM-3607:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 23:06
Start Date: 25/Mar/22 23:06
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #17165:
URL: https://github.com/apache/beam/pull/17165#issuecomment-1079505132
Sure thing! But I will be on vacation next week. I will just take a look to
make sure these are all the places it should be switched. I do think that
probably 100% should be switched, since `checkNotNull` always throws NPE and it
looks like the wrong code is blamed for the NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 748067)
Time Spent: 0.5h (was: 20m)
> Move checkNotNull arg checks to a new checkArgumentNotNull
> ----------------------------------------------------------
>
> Key: BEAM-3607
> URL: https://issues.apache.org/jira/browse/BEAM-3607
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Dominik Schöneweiß
> Priority: P3
> Labels: Clarified, beginner, newbie, starter
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The simple fact is that {{checkNotNull}} throws NPE which to users looks like
> a core dump sort of failure. It throws a "500 error" when we usually intend a
> "400 error", so to speak, so the bugs get filed on the wrong components, or
> users don't know they passed the wrong thing, etc.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
