[
https://issues.apache.org/jira/browse/BEAM-12572?focusedWorklogId=748810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748810
]
ASF GitHub Bot logged work on BEAM-12572:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/22 17:40
Start Date: 28/Mar/22 17:40
Worklog Time Spent: 10m
Work Description: fernando-wizeline commented on a change in pull request
#17015:
URL: https://github.com/apache/beam/pull/17015#discussion_r836685824
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/game/HourlyTeamScore.java
##########
@@ -170,7 +176,7 @@ public static void main(String[] args) throws Exception {
// Extract and sum teamname/score pairs from the event data.
.apply("ExtractTeamScore", new ExtractAndSumScore("team"))
.apply(
- "WriteTeamScoreSums", new WriteToText<>(options.getOutput(),
configureOutput(), true));
+ "WriteTeamScoreSums", new WriteToText<>(options.getOutput(),
configureOutput(), false));
Review comment:
This is just to write the results to one file per round instead of
several files per windowing. The windowing itself is not being changed if I'm
not mistaken.
I added an extra option and set it to true as default to keep the original
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 748810)
Time Spent: 69h 20m (was: 69h 10m)
> All beam examples should get continuously exercised
> ---------------------------------------------------
>
> Key: BEAM-12572
> URL: https://issues.apache.org/jira/browse/BEAM-12572
> Project: Beam
> Issue Type: New Feature
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 69h 20m
> Remaining Estimate: 0h
>
> Sometimes our examples become broken without us noticing. For example, see:
> https://lists.apache.org/thread.html/r45340bbee91a6caf798fe62d24388f645f8792cc7506351fd66adec3%40%3Cdev.beam.apache.org%3E
> We should test our examples better.
> Test examples on Dataflow, Spark, Flink and Direct runners
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
