[
https://issues.apache.org/jira/browse/BEAM-14166?focusedWorklogId=749186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749186
]
ASF GitHub Bot logged work on BEAM-14166:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/22 08:22
Start Date: 29/Mar/22 08:22
Worklog Time Spent: 10m
Work Description: mosche commented on pull request #17172:
URL: https://github.com/apache/beam/pull/17172#issuecomment-1081574040
I've pushed my [benchmark code ](https://github.com/apache/beam/pull/17203)
for reference, let me know if you have any suggestions. To prevent the issue
you've mentioned @reuvenlax, I'm setting up a relatively large number of rows
as JMH state before the actual benchmark invocation.
To establish a baseline, I'm looking at `master` first.
[Here](https://jmh.morethan.io/?sources=https://raw.githubusercontent.com/apache/beam/3b5e1d607d30397abb27a119fc30c5d05a7b2d40/sdks/java/harness/jmh/RowWithGetters-master-cache-disabled.json,https://raw.githubusercontent.com/apache/beam/3b5e1d607d30397abb27a119fc30c5d05a7b2d40/sdks/java/harness/jmh/RowWithGetters-master-cache-enabled-lazy-init.json)
are some initial results with some minimal changes to `RowWithGetters` to make
these benchmarks meaningful:
- Disable caching for the first run.
- Change initialisation of the cache data structure to lazy init so
associated costs are considered in the benchmark.
These numbers are certainly not very much in favour of the status quo.
I'm still iterating on improvements, but from what I've seen so far far
there's lots that can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 749186)
Time Spent: 1h 10m (was: 1h)
> Improvements to RowWithGetter
> -----------------------------
>
> Key: BEAM-14166
> URL: https://issues.apache.org/jira/browse/BEAM-14166
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Various improvements to getValue(fieldIdx) in RowWithGetters mentioned
> [here|[https://github.com/apache/beam/pull/16947#discussion_r833602836]:]
> * Minimize memory overhead of cache using either a index lookup (array) or a
> single hash map if number of fields exceeds the initial hashmap capacity
> * The cache should be checked before calling a getter to avoid any
> potentially unnecessary conversion in the getter itself.
> * [Nested
> rows|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L111]
> should be cached, otherwise the cache of such nested rows can't be leveraged.
> * Handling of collections / maps / iterables can be significantly improved
> by simply skipping the transform in all cases where {{getValue}} for members
> is the [identity
> transform|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L142].
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
