[
https://issues.apache.org/jira/browse/BEAM-14130?focusedWorklogId=749669&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749669
]
ASF GitHub Bot logged work on BEAM-14130:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/22 22:07
Start Date: 29/Mar/22 22:07
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#17127:
URL: https://github.com/apache/beam/pull/17127#discussion_r837948253
##########
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts
##########
@@ -41,30 +41,20 @@ export class SidePanel extends BoxPanel {
constructor(
manager: ServiceManager.IManager,
rendermime: IRenderMimeRegistry,
- pageType: string
+ sessionContext: SessionContext,
+ title: string,
+ widget: ClustersWidget | InteractiveInspectorWidget
Review comment:
You can replace the type here with "ReactWidget" b/c both the
ClustersWidget and InteractiveInspectorWidget extend this.
##########
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts
##########
@@ -130,7 +120,6 @@ export class SidePanel extends BoxPanel {
this.dispose();
}
- private _clusters: ClustersWidget;
- private _inspector: InteractiveInspectorWidget;
+ private _widget: ClustersWidget | InteractiveInspectorWidget;
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 749669)
Time Spent: 25h 10m (was: 25h)
> Implement Jupyterlab extension for managing Dataproc clusters
> -------------------------------------------------------------
>
> Key: BEAM-14130
> URL: https://issues.apache.org/jira/browse/BEAM-14130
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 25h 10m
> Remaining Estimate: 0h
>
> - Adds an additional option under the Interactive Beam Jupyterlab extension
> to enable users to manage Interactive Beam clusters
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
