[ 
https://issues.apache.org/jira/browse/BEAM-14084?focusedWorklogId=749798&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749798
 ]

ASF GitHub Bot logged work on BEAM-14084:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Mar/22 02:00
            Start Date: 30/Mar/22 02:00
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on pull request #17194:
URL: https://github.com/apache/beam/pull/17194#issuecomment-1082537470


   It still sounds like the right thing to do, however it causes a breaking 
change, so we would need to document the breaking change in CHANGES.MD. Given 
that we have the opportunity to onboard this change to the internal customers 
first, I would suggest to do that first, as it could allow us to better word 
the recommendations for the external users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 749798)
    Time Spent: 2h 10m  (was: 2h)

> Fix Iterable todo In CoGroupByKey
> ---------------------------------
>
>                 Key: BEAM-14084
>                 URL: https://issues.apache.org/jira/browse/BEAM-14084
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Ryan Thompson
>            Assignee: Ryan Thompson
>            Priority: P2
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
>  
> Change iterable_input_value_types to be either type.Iterable or rename the 
> variable to specify it is supposed to be a list.
> https://github.com/apache/beam/blob/6e339718c63f14fa3cc6249bec43a1b0e3a32af0/sdks/python/apache_beam/transforms/util.py#L198



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to