[
https://issues.apache.org/jira/browse/BEAM-6942?focusedWorklogId=226295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226295
]
ASF GitHub Bot logged work on BEAM-6942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/19 19:37
Start Date: 11/Apr/19 19:37
Worklog Time Spent: 10m
Work Description: udim commented on pull request #8225: [BEAM-6942] Make
modifications to pipeline options to be visible to all views.
URL: https://github.com/apache/beam/pull/8225#discussion_r274082138
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -117,28 +117,34 @@ def error(self, message):
class PipelineOptions(HasDisplayData):
- """Pipeline options class used as container for command line options.
+ """Subclasses of this class are used as containers for command line options.
- The class is essentially a wrapper over the standard argparse Python module
+ These classes are wrappers over the standard argparse Python module
(see https://docs.python.org/3/library/argparse.html). To define one option
- or a group of options you subclass from PipelineOptions::
+ or a group of options, create a subclass from PipelineOptions:
- class XyzOptions(PipelineOptions):
-
- @classmethod
- def _add_argparse_args(cls, parser):
- parser.add_argument('--abc', default='start')
- parser.add_argument('--xyz', default='end')
+ | class XyzOptions(PipelineOptions):
Review comment:
Is there a reason for these pipe symbols? At least please be consistent with
lines 73-75 above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226295)
Time Spent: 5h 40m (was: 5.5h)
> Pipeline options to experiment propagation is not working in Dataflow runner.
> -----------------------------------------------------------------------------
>
> Key: BEAM-6942
> URL: https://issues.apache.org/jira/browse/BEAM-6942
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Relevant code:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L356-L388]
> 3 experiments/options are affected. We need to fix it in 2.12.0
> cc: [~altay] [~apilloud]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
