[
https://issues.apache.org/jira/browse/BEAM-14130?focusedWorklogId=750600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-750600
]
ASF GitHub Bot logged work on BEAM-14130:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/22 23:08
Start Date: 30/Mar/22 23:08
Worklog Time Spent: 10m
Work Description: KevinGG commented on a change in pull request #17127:
URL: https://github.com/apache/beam/pull/17127#discussion_r839028953
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -443,6 +448,31 @@ def cleanup(
self.master_urls_to_pipelines.clear()
self.master_urls_to_dashboards.clear()
+ def delete_cluster(self, id: str):
Review comment:
Do not leak the obfuscated id from inspector to this module because it's
meaningless in other in-kernel modules.
See the comment for inspector for more details.
You can define this as
```
def delete_cluster(self, master: Union[str, MasterURLIdentifier]):
// get pipelines from self._master_urls_to_pipelines
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 750600)
Time Spent: 39h 40m (was: 39.5h)
> Implement Jupyterlab extension for managing Dataproc clusters
> -------------------------------------------------------------
>
> Key: BEAM-14130
> URL: https://issues.apache.org/jira/browse/BEAM-14130
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 39h 40m
> Remaining Estimate: 0h
>
> - Adds an additional option under the Interactive Beam Jupyterlab extension
> to enable users to manage Interactive Beam clusters
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
