[
https://issues.apache.org/jira/browse/BEAM-14179?focusedWorklogId=751095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751095
]
ASF GitHub Bot logged work on BEAM-14179:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/22 17:05
Start Date: 31/Mar/22 17:05
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #17228:
URL: https://github.com/apache/beam/pull/17228#issuecomment-1084861499
LGTM. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 751095)
Time Spent: 20m (was: 10m)
> MonitoringInfoMetricName null value guard uncovering additional issues
> ----------------------------------------------------------------------
>
> Key: BEAM-14179
> URL: https://issues.apache.org/jira/browse/BEAM-14179
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Daniel Oliveira
> Priority: P2
> Fix For: 2.38.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Additional integration testing
> (//cloud/dataflow/testing/integration/sdk:V1ReadIT_testE2EV1Read) caught that
> https://github.com/apache/beam/pull/17094 causes a regression:
> The test failed with:
> {noformat}
> Caused by: java.lang.NullPointerException: null value in entry:
> DATASTORE_NAMESPACE=null
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:32)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:100)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.RegularImmutableMap.fromEntries(RegularImmutableMap.java:74)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:464)
> at
> org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:437)
> at
> org.apache.beam.runners.core.metrics.MonitoringInfoMetricName.<init>(MonitoringInfoMetricName.java:46)
> at
> org.apache.beam.runners.core.metrics.MonitoringInfoMetricName.named(MonitoringInfoMetricName.java:93)
> at
> org.apache.beam.runners.core.metrics.ServiceCallMetric.call(ServiceCallMetric.java:82)
> at
> org.apache.beam.sdk.io.gcp.datastore.DatastoreV1$Read$ReadFn.runQueryWithRetries(DatastoreV1.java:927)
> at
> org.apache.beam.sdk.io.gcp.datastore.DatastoreV1$Read$ReadFn.processElement(DatastoreV1.java:965)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
