[
https://issues.apache.org/jira/browse/BEAM-14205?focusedWorklogId=751223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751223
]
ASF GitHub Bot logged work on BEAM-14205:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/22 20:44
Start Date: 31/Mar/22 20:44
Worklog Time Spent: 10m
Work Description: KonradJanica commented on a change in pull request
#17225:
URL: https://github.com/apache/beam/pull/17225#discussion_r839851756
##########
File path:
playground/frontend/lib/modules/examples/repositories/models/get_example_request.dart
##########
@@ -23,4 +23,14 @@ class GetExampleRequestWrapper {
final SDK sdk;
GetExampleRequestWrapper(this.path, this.sdk);
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetExampleRequestWrapper &&
+ path == other.path &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => path.hashCode ^ sdk.hashCode;
Review comment:
Nit: Flutter has the
[hashValues](https://api.flutter.dev/flutter/dart-ui/hashValues.html) function
which is more standard.
##########
File path:
playground/frontend/lib/modules/examples/repositories/models/get_list_of_examples_request.dart
##########
@@ -23,4 +23,14 @@ class GetListOfExamplesRequestWrapper {
final String? category;
GetListOfExamplesRequestWrapper({required this.sdk, required this.category});
+
+ @override
+ bool operator ==(Object other) =>
+ identical(this, other) ||
+ other is GetListOfExamplesRequestWrapper &&
+ category == other.category &&
+ sdk == other.sdk;
+
+ @override
+ int get hashCode => category.hashCode ^ sdk.hashCode;
Review comment:
Nit: Flutter has the
[hashValues](https://api.flutter.dev/flutter/dart-ui/hashValues.html) function
which is more standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 751223)
Time Spent: 0.5h (was: 20m)
> [Playground] Tests for app states
> ---------------------------------
>
> Key: BEAM-14205
> URL: https://issues.apache.org/jira/browse/BEAM-14205
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Alexander Zhuravlev
> Assignee: Alexander Zhuravlev
> Priority: P2
> Labels: beam-playground-frontend
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
