[
https://issues.apache.org/jira/browse/BEAM-14014?focusedWorklogId=751693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751693
]
ASF GitHub Bot logged work on BEAM-14014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/22 17:12
Start Date: 01/Apr/22 17:12
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r840775779
##########
File path: sdks/python/apache_beam/internal/gcp/auth.py
##########
@@ -125,30 +139,22 @@ def get_service_credentials(cls):
"socket default timeout is %s seconds.", socket.getdefaulttimeout())
cls._credentials = cls._get_service_credentials()
+ cls._add_impersonation_credentials()
cls._credentials_init = True
return cls._credentials
@staticmethod
- def _get_service_credentials():
+ def _get_service_credentials(cls):
if not _GOOGLE_AUTH_AVAILABLE:
_LOGGER.warning(
'Unable to find default credentials because the google-auth library '
'is not available. Install the gcp extra (apache_beam[gcp]) to use '
'Google default credentials. Connecting anonymously.')
return None
- client_scopes = [
- 'https://www.googleapis.com/auth/bigquery',
Review comment:
+1. That will make things much more consistent for x-lang (and users of
different SDKs in general).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 751693)
Time Spent: 40m (was: 0.5h)
> Support impersonation credentials in Dataflow runner.
> -----------------------------------------------------
>
> Key: BEAM-14014
> URL: https://issues.apache.org/jira/browse/BEAM-14014
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
