[jira] [Work logged] (BEAM-11105) [Go SDK] Watermark Estimation

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-11105?focusedWorklogId=752431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752431
 ]

ASF GitHub Bot logged work on BEAM-11105:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/22 18:41
            Start Date: 04/Apr/22 18:41
    Worklog Time Spent: 10m 
      Work Description: damccorm opened a new pull request, #17267:
URL: https://github.com/apache/beam/pull/17267

   **Summary of Changes**
   
   This pr is the first step towards full watermark estimation support - it 
introduces the mechanism used for watermark estimation including:
   
   - Validation (graph/fn.go)
   - Code generation (genx/genx.go)
   - Execution (exec/sdf.go and exec/sdf_invokers.go)
   - Propogating result back to the runner (exec/datasource.go, harness.go)
   - A concrete implementation of a wall clock observing estimator 
(sdf/watermarkEstimator.go)
   
   This is built according to the design specified here - 
https://docs.google.com/document/d/1DqCYJ-J1YGNelCRIcN5v6BQsZxJB2l5uWBmN4ti--Ew/edit?usp=sharing
   
   **Next Steps**
   
   This work does not attempt any of the following (though it is built in such 
a way that those should be cleanly supported in subsequent PRs):
   
   - Watermark state
   - Manual estimators (passed into ProcessElement)
   - Timestamp observing estimators (call ObserveTimestamp on each emitted 
timestamp)
   
   **Manual Testing**
   
   On top of all the unit tests introduced, I hacked the existing textio sdf 
doFn and added the following function:
   
   ```
   func (fn *readSdfFn) CreateWatermarkEstimator() 
sdf.WallTimeWatermarkEstimator {
        return sdf.WallTimeWatermarkEstimator{}
   }
   ```
   
   and ran wordCount (with the textio sdf version) on dataflow so that I could 
observe the output watermark was getting correctly updated to the current wall 
clock time:
   
   <img width="464" alt="image" 
src="https://user-images.githubusercontent.com/42773683/161610141-f38ce9f0-a598-45bd-aa5b-869c465300a5.png";>
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 752431)
    Remaining Estimate: 0h
            Time Spent: 10m

> [Go SDK] Watermark Estimation
> -----------------------------
>
>                 Key: BEAM-11105
>                 URL: https://issues.apache.org/jira/browse/BEAM-11105
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Danny McCormick
>            Priority: P3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Allow self checkpointing SplittableDoFns to specify a watermark estimator.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and 
> the programming guide updated with SDF content.)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)