[
https://issues.apache.org/jira/browse/BEAM-13015?focusedWorklogId=752517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752517
]
ASF GitHub Bot logged work on BEAM-13015:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 21:31
Start Date: 04/Apr/22 21:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on code in PR #17243:
URL: https://github.com/apache/beam/pull/17243#discussion_r842156693
##########
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/channel/ManagedChannelFactory.java:
##########
@@ -89,6 +89,11 @@ public ManagedChannel forDescriptor(ApiServiceDescriptor
apiServiceDescriptor) {
// Set the message size to max value here. The actual size is
governed by the
// buffer size in the layers above.
.maxInboundMessageSize(Integer.MAX_VALUE)
+ // Disable automatic retries as it introduces complexity and we
send long-lived
+ // rpcs which will exceed the per-rpc retry request buffer and not
be retried
+ // anyway. See
+ //
https://github.com/grpc/proposal/blob/master/A6-client-retries.md#when-retries-are-valid
Review Comment:
```suggestion
// Disable automatic retries as it introduces complexity and we
send long-lived
// rpcs which will exceed the per-rpc retry request buffer and
not be retried
// anyway. See
//
https://github.com/grpc/proposal/blob/master/A6-client-retries.md#when-retries-are-valid
```
Issue Time Tracking
-------------------
Worklog Id: (was: 752517)
Time Spent: 73h 40m (was: 73.5h)
> Optimize Java SDK harness
> -------------------------
>
> Key: BEAM-13015
> URL: https://issues.apache.org/jira/browse/BEAM-13015
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 73h 40m
> Remaining Estimate: 0h
>
> Use profiling tools to remove bundle processing overhead in the SDK harness.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
