[
https://issues.apache.org/jira/browse/BEAM-13829?focusedWorklogId=752905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752905
]
ASF GitHub Bot logged work on BEAM-13829:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/22 13:56
Start Date: 05/Apr/22 13:56
Worklog Time Spent: 10m
Work Description: riteshghorse commented on code in PR #16957:
URL: https://github.com/apache/beam/pull/16957#discussion_r842817089
##########
sdks/go/pkg/beam/core/runtime/harness/harness.go:
##########
@@ -98,6 +111,18 @@ func Main(ctx context.Context, loggingEndpoint,
controlEndpoint string) error {
log.Debugf(ctx, "control response channel closed")
}()
+ // if the runner supports worker status api then expose SDK harness
status
+ if statusEndpoint != "" {
+ statusHandler, err := newWorkerStatusHandler(ctx,
statusEndpoint)
+ if err != nil {
+ log.Errorf(ctx, "error establishing connection to
worker status API: %v", err)
+ } else {
+ statusHandler.wg.Add(1)
Review Comment:
Makes sense
Issue Time Tracking
-------------------
Worklog Id: (was: 752905)
Time Spent: 9h 40m (was: 9.5h)
> Expose status api from Go SDK Harness
> -------------------------------------
>
> Key: BEAM-13829
> URL: https://issues.apache.org/jira/browse/BEAM-13829
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P2
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Expose status api handle from Go SDK harness to runner.
> Doc link:
> https://docs.google.com/document/d/1dMTD5_sKdzLcnoe0ZsQU5Wf9q11uliyYgFnnOZQDzuI/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
