[
https://issues.apache.org/jira/browse/BEAM-13519?focusedWorklogId=753114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753114
]
ASF GitHub Bot logged work on BEAM-13519:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/22 21:28
Start Date: 05/Apr/22 21:28
Worklog Time Spent: 10m
Work Description: youngoli opened a new pull request, #17295:
URL: https://github.com/apache/beam/pull/17295
* [BEAM-13519] Solve race issues when the server responds with an error
before the GrpcStateClient finishes.
The issue was that the InboundObserver can be invoked before
outboundObserverFactory#outboundObserverFor returns meaning that
the server is waiting for a response for cache.remove but
cache.computeIfAbsent is being invoked at the same time.
Another issue was that the outstandingRequests map could be updated with
another request within GrpcStateClient during closeAndCleanup meaning that the
CompleteableFuture would never be completed exceptionally.
Passes 1000 times locally now without getting stuck or failing.
(cherry picked from commit 0262ee53c6018d929a8a40fdf66735cc7e934951)
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 753114)
Time Spent: 2h 20m (was: 2h 10m)
> Java precommit flaky (timing out)
> ---------------------------------
>
> Key: BEAM-13519
> URL: https://issues.apache.org/jira/browse/BEAM-13519
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Kyle Weaver
> Assignee: Kiley Sok
> Priority: P1
> Labels: flake
> Fix For: 2.38.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Java precommits are sometimes timing out with no clear cause. Gradle will log
> a bunch of routine build tasks, and then Jenkins will abort the job much
> later. There are no logs to indicate what happened. It is not even clear
> which task or tasks, if any, was the culprit, since many tasks are run in
> parallel.
> 01:53:28 > Task :sdks:java:testing:nexmark:build
> 01:53:28 > Task :sdks:java:testing:nexmark:buildDependents
> 01:53:28 > Task :sdks:java:extensions:sql:zetasql:buildDependents
> 01:53:28 > Task :sdks:java:io:google-cloud-platform:buildDependents
> 01:53:28 > Task :sdks:java:extensions:sql:buildDependents
> 01:53:28 > Task :sdks:java:io:kafka:buildDependents
> 01:53:28 > Task :sdks:java:extensions:join-library:buildDependents
> 01:53:28 > Task :sdks:java:io:synthetic:buildDependents
> 01:53:28 > Task :sdks:java:io:mongodb:buildDependents
> 01:53:28 > Task :sdks:java:io:thrift:buildDependents
> 01:53:28 > Task :sdks:java:testing:test-utils:buildDependents
> 01:53:28 > Task :sdks:java:expansion-service:buildDependents
> 01:53:28 > Task :sdks:java:extensions:arrow:buildDependents
> 01:53:28 > Task :sdks:java:extensions:protobuf:buildDependents
> 01:53:28 > Task :sdks:java:io:common:buildDependents
> 01:53:28 > Task :runners:direct-java:buildDependents
> 01:53:28 > Task :runners:local-java:buildDependents
> 01:53:28 Build timed out (after 120 minutes). Marking the build as aborted.
> https://ci-beam.apache.org/job/beam_PreCommit_Java_cron/4874/
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
