[ 
https://issues.apache.org/jira/browse/BEAM-12164?focusedWorklogId=753761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753761
 ]

ASF GitHub Bot logged work on BEAM-12164:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Apr/22 23:00
            Start Date: 06/Apr/22 23:00
    Worklog Time Spent: 10m 
      Work Description: hengfengli commented on code in PR #17200:
URL: https://github.com/apache/beam/pull/17200#discussion_r844489873


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/TimestampUtils.java:
##########
@@ -30,6 +30,11 @@
       BigDecimal.valueOf(Timestamp.MIN_VALUE.getSeconds());
   private static final int NANOS_PER_SECOND = (int) 
TimeUnit.SECONDS.toNanos(1);
 
+  /** This interface is only used for replacing now() with a constant 
timestamp for testing. */
+  public interface TimeFunction {

Review Comment:
   Nice suggestion. Updated. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 753761)
    Time Spent: 67.5h  (was: 67h 20m)

> SpannerIO Change Stream Connector
> ---------------------------------
>
>                 Key: BEAM-12164
>                 URL: https://issues.apache.org/jira/browse/BEAM-12164
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Thiago Nunes
>            Assignee: Thiago Nunes
>            Priority: P2
>             Fix For: 2.37.0
>
>          Time Spent: 67.5h
>  Remaining Estimate: 0h
>
> We would like to augment the existing Google Cloud SpannerIO connector 
> ([https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java)]
>  with the support for Spanner Change Streams (CDC). CDC support is just being 
> implemented in Spanner and it will be exposed through a gRPC API. We will use 
> such API to create a new SpannerIO.readChangeStream(...) implementation.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to