[ 
https://issues.apache.org/jira/browse/BEAM-14236?focusedWorklogId=753782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753782
 ]

ASF GitHub Bot logged work on BEAM-14236:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Apr/22 23:48
            Start Date: 06/Apr/22 23:48
    Worklog Time Spent: 10m 
      Work Description: Shiv22Wabale commented on code in PR #17279:
URL: https://github.com/apache/beam/pull/17279#discussion_r844521163


##########
sdks/python/apache_beam/io/parquetio_test.py:
##########
@@ -109,6 +111,37 @@ def setUp(self):
                                ('favorite_number', pa.timestamp('ns'), False),
                                ('favorite_color', pa.string())])
 
+    self.RECORDS_NESTED = [{
+        'items': [
+            {
+                'name': 'Thomas',
+                'favorite_number': 1,
+                'favorite_color': 'blue'
+            },
+            {
+                'name': 'Henry',
+                'favorite_number': 3,
+                'favorite_color': 'green'
+            },
+        ]
+    },
+                           {

Review Comment:
   Yes, it is correct from PythonFormatter.
   
   If I keep the it with same level with the previous item, the PythonFormatter 
PreCommit fails.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 753782)
    Time Spent: 3h  (was: 2h 50m)

> [Python] Write to Parquet support for list to conform with Apache Parquet 
> specification
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-14236
>                 URL: https://issues.apache.org/jira/browse/BEAM-14236
>             Project: Beam
>          Issue Type: Bug
>          Components: io-py-parquet
>            Reporter: Shivraj Devidas Wabale
>            Assignee: Shivraj Devidas Wabale
>            Priority: P2
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> ARROW-11497 The pyarrow parquet writer now support the list type contains 3 
> level where the middle level, named {{{}list{}}}, must be a repeated group 
> with a single field named _{{element. 
> [https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists|https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists,]}}_
> I think we can simply populate it to [WriteToParquet 
> |https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/parquetio.py#L358]by
>  adding additional flag (use_compliant_nested_type) to 
>  conform with Apache Parquet specification.
> h4.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to