[ 
https://issues.apache.org/jira/browse/BEAM-13939?focusedWorklogId=754685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754685
 ]

ASF GitHub Bot logged work on BEAM-13939:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Apr/22 16:08
            Start Date: 08/Apr/22 16:08
    Worklog Time Spent: 10m 
      Work Description: asf-ci commented on PR #16961:
URL: https://github.com/apache/beam/pull/16961#issuecomment-1093046867

   Can one of the admins verify this patch?




Issue Time Tracking
-------------------

    Worklog Id:     (was: 754685)
    Time Spent: 29h 10m  (was: 29h)

> Go SDK: Protobuf namespace conflict
> -----------------------------------
>
>                 Key: BEAM-13939
>                 URL: https://issues.apache.org/jira/browse/BEAM-13939
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-go
>    Affects Versions: 2.36.0
>            Reporter: Milan Patel
>            Assignee: Milan Patel
>            Priority: P2
>             Fix For: 2.39.0
>
>         Attachments: demobug.zip
>
>          Time Spent: 29h 10m
>  Remaining Estimate: 0h
>
> The Go SDK generated grpc protobufs are not namespaced with enough 
> granularity. If a user has another external dependency with the same protobuf 
> file registered with the proto runtime, their compiled binary will panic at 
> runtime pointing the user to this [doc 
> page|https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict].
>  
> In the interim, following the instructions to add either ldflags to the 
> compiler or an environment var to the binary works, but this is an unideal 
> solution since only one of the duplicate proto specifications will be 
> accessible from a [global 
> registry|https://pkg.go.dev/google.golang.org/[email protected]/reflect/protoregistry].
>  
> Ask: Regenerate the go protos such that descriptors like 
> [these|https://github.com/apache/beam/blob/84353a7c973d3acaaa56d81c265dce7193a56be5/sdks/go/pkg/beam/model/pipeline_v1/metrics.pb.go#L797-L811]
>  are outputted with filenames that are more granular, such as a filename that 
> includes the directory structure of the repository.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to