[
https://issues.apache.org/jira/browse/BEAM-13898?focusedWorklogId=754841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754841
]
ASF GitHub Bot logged work on BEAM-13898:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/22 22:36
Start Date: 08/Apr/22 22:36
Worklog Time Spent: 10m
Work Description: lostluck opened a new pull request, #17324:
URL: https://github.com/apache/beam/pull/17324
Use the pstest fake pubsub server to test the pubsubx package.
Adds unit test coverage, and does small refactors to allow testing of the
existing helper methods with the fake client.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 754841)
Remaining Estimate: 0h
Time Spent: 10m
> Add unit testing to the pubsubx package
> ---------------------------------------
>
> Key: BEAM-13898
> URL: https://issues.apache.org/jira/browse/BEAM-13898
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add basic unit testing to the [pubsubx
> package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/util/pubsubx]
> We want code coverage at or above 50%, it is currently at 0%.
> This task largely involves mocking PubSub clients.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
