[jira] [Work logged] (BEAM-14121) Incorrect Spanner IO Request Count metrics

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-14121?focusedWorklogId=755268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755268
 ]

ASF GitHub Bot logged work on BEAM-14121:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 15:34
            Start Date: 11/Apr/22 15:34
    Worklog Time Spent: 10m 
      Work Description: nielm opened a new pull request, #17335:
URL: https://github.com/apache/beam/pull/17335

   Fixes issues with the ServiceCallMetrics in SpannerIO: 
   
   - Fixes metric resource identifiers: 
      - 
`//spanner.googleapis.com/projects/{projectId}/instances/{instanceId}/databases/{databaseId}/tables/{tableId}`
      - 
`//spanner.googleapis.com/projects/{projectId}/instances/{instanceId}/queries/{queryName}`
   - Ensure a non-null value for `{queryName}`
   - Fix metrics generation in `SpannerIO.Read`
   - Fix metrics generation in `SpannerIO.Write`
   - Add metrics generation to `NaiveSpannerRead`.
   - Refactor and improve `SpannerIOReadTest` to add additional coverage and 
verify metrics values
   - Add unit tests for `NaiveSpannerRead` (non-partitioned read)
   - Add metrics value verification in `SpannerIOWriteTest`.
    
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 755268)
    Remaining Estimate: 39h 50m  (was: 40h)
            Time Spent: 10m

> Incorrect Spanner IO Request Count metrics
> ------------------------------------------
>
>                 Key: BEAM-14121
>                 URL: https://issues.apache.org/jira/browse/BEAM-14121
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.34.0
>            Reporter: Niel Markwick
>            Assignee: Niel Markwick
>            Priority: P2
>              Labels: google-cloud-spanner
>   Original Estimate: 40h
>          Time Spent: 10m
>  Remaining Estimate: 39h 50m
>
> IO request count metrics calculated incorrectly for GCP Spanner
>  
> Resource ID is formulated incorrectly
> *Spanner Table:*
> {{//spanner.googleapis.com/projects/\{projectId}/{*}topics{*}/\{databaseId}/tables/\{tableId}}}
> should be
> {{//spanner.googleapis.com/projects/\{projectId}/instances/\{instanceId}/databases/\{databaseId}/tables/\{tableId}}}
> and is populated incorrectly – instance ID is used in place of tableID
> Spanner SQL Query:
> {{//spanner.googleapis.com/projects/\{projectId}/queries/\{queryName} }}
> {{should be}}
> {{{}//spanner.googleapis.com/projects/\{projectId}/{}}}{{{}instances/\{instanceId}/queries{}}}{{{}/\{queryName}
>  {}}}
> and queryName is nullable which cause issued downstream
> this is not actually populated at all - queries are logged as reads on an 
> instance. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)