[ 
https://issues.apache.org/jira/browse/BEAM-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521399#comment-17521399
 ] 

Daniel Oliveira commented on BEAM-14282:
----------------------------------------

This has been cherry-picked into 2.38.0, so assuming there's no further work it 
should be safe to resolve.

> Fix exceptions swallowed in several Python I/O connectors
> ---------------------------------------------------------
>
>                 Key: BEAM-14282
>                 URL: https://issues.apache.org/jira/browse/BEAM-14282
>             Project: Beam
>          Issue Type: Bug
>          Components: io-py-gcp
>    Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Chamikara Madhusanka Jayalath
>            Priority: P1
>             Fix For: 2.38.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Seems like we do not re-throw errors after reporting metrics at following 
> locations.
> https://github.com/apache/beam/blob/8e217ea0d1f383ef5033ef507b14d01edf9c67e6/sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py#L303
> https://github.com/apache/beam/blob/70d9e2a08cc32192790cd9c98ffa15a756877a73/sdks/python/apache_beam/io/gcp/gcsio.py#L644
> Not re-raising these errors could result in data correctness issues for 
> downstream consumers.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to