[
https://issues.apache.org/jira/browse/BEAM-14303?focusedWorklogId=756481&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756481
]
ASF GitHub Bot logged work on BEAM-14303:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 15:53
Start Date: 13/Apr/22 15:53
Worklog Time Spent: 10m
Work Description: zhengbuqian commented on code in PR #17359:
URL: https://github.com/apache/beam/pull/17359#discussion_r849639066
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -1251,7 +1262,7 @@ private void setAndVerifyOutputTimestamp() {
:
PeriodFormat.getDefault().print(fn.getAllowedTimestampSkew().toPeriod()),
BoundedWindow.TIMESTAMP_MAX_VALUE));
}
- } else if (TimeDomain.EVENT_TIME.equals(spec.getTimeDomain())) {
+ } else if (!noOutputTimestamp &&
TimeDomain.EVENT_TIME.equals(spec.getTimeDomain())) {
Review Comment:
Seems if the user called `withNoOutputTimestamp()` on an event time timer,
the `else` branch will be executed. Is this expected? I don't see any code
preventing the user from doing so. I guess the answer is yes because if
`withNoOutputTimestamp()` is called then the outputTimestamp value doesn't
matter as we don't allow output from this timer. If so then the comment should
also be updated.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java:
##########
@@ -99,6 +99,12 @@ public interface Timer {
*/
Timer withOutputTimestamp(Instant outputTime);
+ /**
+ * Asserts that there is no output timestamp. The output watermark will not
be held up, and it is
+ * illegal to output messages from this timer.
Review Comment:
> it is illegal to output messages from this timer.
How is this enforced?
Issue Time Tracking
-------------------
Worklog Id: (was: 756481)
Time Spent: 1h 50m (was: 1h 40m)
> Allow a timer to have no watermark hold
> ---------------------------------------
>
> Key: BEAM-14303
> URL: https://issues.apache.org/jira/browse/BEAM-14303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
