[
https://issues.apache.org/jira/browse/BEAM-14170?focusedWorklogId=756682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756682
]
ASF GitHub Bot logged work on BEAM-14170:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 20:36
Start Date: 13/Apr/22 20:36
Worklog Time Spent: 10m
Work Description: pabloem commented on code in PR #17354:
URL: https://github.com/apache/beam/pull/17354#discussion_r849877962
##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PostcommitJobBuilder
+
+import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
Review Comment:
let's make sure that these tests run on a schedule (maybe every 12 hours or
so)
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -124,6 +124,30 @@ task postCommitIT {
}
}
+task postCommitSickbay {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ dependsOn ':runners:google-cloud-dataflow-java:worker:shadowJar'
+
+ def dataflowWorkerJar =
project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath
Review Comment:
I don't think we need this. I'd like to run these on Runner V2 only. Do you
know how to set this up as a Runner V2 test?
##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -121,8 +121,9 @@ def test_copy_kms(self):
raise unittest.SkipTest('--kms_key_name not specified')
self._test_copy("test_copy_kms", self.kms_key_name)
- @pytest.mark.it_postcommit
- @unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works
again')
+ @pytest.mark.it_postcommit_sickbay
+ #@pytest.mark.it_postcommit Enable when this test is not more sickbay
+ #@unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works
again')
Review Comment:
ditto
##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -175,8 +176,9 @@ def test_copy_batch_kms(self):
raise unittest.SkipTest('--kms_key_name not specified')
self._test_copy_batch("test_copy_batch_kms", self.kms_key_name)
- @pytest.mark.it_postcommit
- @unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works
again')
+ @pytest.mark.it_postcommit_sickbay
+ #@pytest.mark.it_postcommit Enable when this test is not sickbay
+ #@unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works
again')
Review Comment:
remove the unittest.skip line please? but leave BEAM-12352 in a comment
Issue Time Tracking
-------------------
Worklog Id: (was: 756682)
Time Spent: 2h (was: 1h 50m)
> Create a test that runs sickbayed tests
> ---------------------------------------
>
> Key: BEAM-14170
> URL: https://issues.apache.org/jira/browse/BEAM-14170
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Kiley Sok
> Assignee: Andoni Guzman
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When we sickbay tests we should continue to run them, at least in a new test
> suite that may hold flaky/sickbayed tests - often we just stop running them
> forever.
> Create a new test for Python and Java that runs the current sickbayed tests.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
