[ 
https://issues.apache.org/jira/browse/BEAM-13608?focusedWorklogId=756981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756981
 ]

ASF GitHub Bot logged work on BEAM-13608:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/22 14:34
            Start Date: 14/Apr/22 14:34
    Worklog Time Spent: 10m 
      Work Description: rvballada commented on code in PR #17163:
URL: https://github.com/apache/beam/pull/17163#discussion_r850509085


##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/SerializableMessageMapper.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.jms;
+
+import javax.jms.Message;
+import javax.jms.Session;
+import org.apache.beam.sdk.transforms.SerializableBiFunction;
+
+/**
+ * SerializableMessageMapper Takes a {@link String} value, a {@link 
javax.jms.Session} and returns a
+ * {@link javax.jms.Message}.
+ */
+public interface SerializableMessageMapper<EventT>

Review Comment:
   Yes you're right





Issue Time Tracking
-------------------

    Worklog Id:     (was: 756981)
    Time Spent: 1h 20m  (was: 1h 10m)

> Dynamic Topics management
> -------------------------
>
>                 Key: BEAM-13608
>                 URL: https://issues.apache.org/jira/browse/BEAM-13608
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-jms
>            Reporter: Vincent BALLADA
>            Assignee: Vincent BALLADA
>            Priority: P2
>              Labels: assigned:
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> JmsIO write function is able to publish messages to topics with static names:
> company/employee/id/1234567.
> Some AMQP/JMS broker provides the ability to publish to dynamic topics like:
> company/employee/id/\{employeeId}
> If we want to handle that with Apache Beam JmsIO, we must create a branch per 
> employeeId, which is not suitable for a company with thousand of employee, or 
> other similat use cases.
> The JmsIO write function should provide the ability to handle dynamic topics.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to