[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=226998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226998
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/19 23:02
Start Date: 12/Apr/19 23:02
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #8273: [BEAM-4461]
A transform to perform binary joins of PCollections with schemas
URL: https://github.com/apache/beam/pull/8273#discussion_r274585649
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/CoGroup.java
##########
@@ -159,7 +159,7 @@
*
* <pre>{@code
* PCollection<Row> joined = PCollectionTuple.of("input1", input1, "input2",
input2)
- * .apply(CoGroup.join("input1",
By.fieldNames("user").withOuterJoinParticipation())
+ * .apply(CoGroup.join("input1",
By.fieldNames("user").withOptionalParticipation())
Review comment:
Nit: update doc at L152 as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226998)
Time Spent: 25h 20m (was: 25h 10m)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Labels: triaged
> Time Spent: 25h 20m
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
