[ 
https://issues.apache.org/jira/browse/BEAM-14305?focusedWorklogId=757204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757204
 ]

ASF GitHub Bot logged work on BEAM-14305:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/22 20:16
            Start Date: 14/Apr/22 20:16
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on PR #17377:
URL: https://github.com/apache/beam/pull/17377#issuecomment-1099585691

   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/17377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#17377](https://codecov.io/gh/apache/beam/pull/17377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (60a9a4b) into 
[master](https://codecov.io/gh/apache/beam/commit/2aa24dc3758750bd76c024dc787c06b91fd725ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (2aa24dc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17377   +/-   ##
   =======================================
     Coverage   73.99%   73.99%           
   =======================================
     Files         685      685           
     Lines       89727    89735    +8     
   =======================================
   + Hits        66395    66401    +6     
   - Misses      22172    22174    +2     
     Partials     1160     1160           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.68% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/17377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/17377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=)
 | `88.01% <0.00%> (-1.39%)` | :arrow_down: |
   | 
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/17377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
 | `92.25% <0.00%> (-0.71%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/17377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5)
 | `86.18% <0.00%> (-0.04%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/textio.py](https://codecov.io/gh/apache/beam/pull/17377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdGV4dGlvLnB5)
 | `96.89% <0.00%> (+0.11%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/17377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==)
 | `88.44% <0.00%> (+0.12%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/17377/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
 | `93.00% <0.00%> (+1.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/17377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/17377?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[2aa24dc...60a9a4b](https://codecov.io/gh/apache/beam/pull/17377?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 757204)
    Time Spent: 50m  (was: 40m)

> Add call in RunInference API
> ----------------------------
>
>                 Key: BEAM-14305
>                 URL: https://issues.apache.org/jira/browse/BEAM-14305
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Ryan Thompson
>            Assignee: Andy Ye
>            Priority: P2
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Right now beam.ml.inference.api.RunInference does not call anything and is an 
> empty API.
>  
> It should call base.RunInference.
>  
> We should also investigate changing the api to work more like a transform.
>  
> Right now it might look like this:
> api.RunInference(pcollection, modelLoader)
>  
> but we might want it to follow other transforms and have it run like this:
>  
> pcollection | api.RunInference(modelLoader)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to