[
https://issues.apache.org/jira/browse/BEAM-14145?focusedWorklogId=757333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757333
]
ASF GitHub Bot logged work on BEAM-14145:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/22 07:33
Start Date: 15/Apr/22 07:33
Worklog Time Spent: 10m
Work Description: nausharipov commented on code in PR #17205:
URL: https://github.com/apache/beam/pull/17205#discussion_r851117062
##########
website/www/site/assets/js/quotes-slider.js:
##########
@@ -10,33 +10,32 @@
// License for the specific language governing permissions and limitations
under
// the License.
-var slider = new KeenSlider("#my-keen-slider", {
- loop: true,
- created: function (instance) {
- var dots_wrapper = document.getElementById("dots");
- var slides = document.querySelectorAll(".keen-slider__slide");
- slides.forEach(function (t, idx) {
- var dot = document.createElement("button");
- dot.classList.add("dot");
- dots_wrapper.appendChild(dot);
- dot.addEventListener("click", function () {
- instance.moveToSlide(idx);
- });
- });
- updateClasses(instance);
- },
- slideChanged(instance) {
- updateClasses(instance);
+$(document).ready(function(){
+ const SelectorNames = {
Review Comment:
I think using strings without constants like SelectorNames increases
readability in this case:
`$('.slick-JS').slick({`
...
`appendDots: '.dots-wrapper',
`dotsClass: 'dots',`
Issue Time Tracking
-------------------
Worklog Id: (was: 757333)
Time Spent: 3h 20m (was: 3h 10m)
> [Website] Add carousel on the Home Page for They tried it out section
> ---------------------------------------------------------------------
>
> Key: BEAM-14145
> URL: https://issues.apache.org/jira/browse/BEAM-14145
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Aydar Zaynutdinov
> Assignee: Bulat Safiullin
> Priority: P3
> Labels: website
> Attachments: image-2022-03-23-05-45-05-105.png,
> image-2022-03-24-11-13-06-901.png
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Need to add a carousel on the Home Page for They tried it out section.
>
> !image-2022-03-23-05-45-05-105.png|width=503,height=233!
> * Carousel similar to [Istio: |http://example.com/]
> [https://istio.io/latest/]
> * Show 3 cards at once, no autorotation
> * Users can look at other cards by using the dots below the menu
> !image-2022-03-24-11-13-06-901.png|width=400,height=227!
>
> Add 2 more logos to carousel:
> Google Cloud Dataflow:
> "Google Cloud Dataflow is a fully managed service for executing Apache Beam
> pipelines within the Google Cloud Platform ecosystem."
> Scio:
> "Scio is a Scala API for Apache Beam and Google Cloud Dataflow inspired by
> Apache Spark and Scalding."
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
