[
https://issues.apache.org/jira/browse/BEAM-8388?focusedWorklogId=757367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757367
]
ASF GitHub Bot logged work on BEAM-8388:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/22 09:19
Start Date: 15/Apr/22 09:19
Worklog Time Spent: 10m
Work Description: RustedBones commented on code in PR #16271:
URL: https://github.com/apache/beam/pull/16271#discussion_r851170588
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroGenericCoder.java:
##########
@@ -18,15 +18,31 @@
package org.apache.beam.sdk.coders;
import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericDatumReader;
+import org.apache.avro.generic.GenericDatumWriter;
import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.io.DatumReader;
+import org.apache.avro.io.DatumWriter;
/** AvroCoder specialisation for GenericRecord. */
public class AvroGenericCoder extends AvroCoder<GenericRecord> {
- AvroGenericCoder(Schema schema) {
+
+ public AvroGenericCoder(Schema schema) {
Review Comment:
Constructor need to be accessed from `AvroCoder` and users should be able to
extends the class to create their own coder
Issue Time Tracking
-------------------
Worklog Id: (was: 757367)
Remaining Estimate: 14h 10m (was: 14h 20m)
Time Spent: 9h 50m (was: 9h 40m)
> Update Avro to 1.9.1 from 1.8.2
> -------------------------------
>
> Key: BEAM-8388
> URL: https://issues.apache.org/jira/browse/BEAM-8388
> Project: Beam
> Issue Type: Improvement
> Components: io-java-avro
> Reporter: Jordanna Chord
> Priority: P3
> Original Estimate: 24h
> Time Spent: 9h 50m
> Remaining Estimate: 14h 10m
>
> Update build dependency to 1.9.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
