[
https://issues.apache.org/jira/browse/BEAM-14286?focusedWorklogId=758631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758631
]
ASF GitHub Bot logged work on BEAM-14286:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/22 17:26
Start Date: 19/Apr/22 17:26
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17392:
URL: https://github.com/apache/beam/pull/17392#discussion_r853319138
##########
sdks/go/pkg/beam/core/runtime/harness/init/init.go:
##########
@@ -43,7 +43,6 @@ var (
loggingEndpoint = flag.String("logging_endpoint", "", "Local logging
gRPC endpoint (required in worker mode).")
controlEndpoint = flag.String("control_endpoint", "", "Local control
gRPC endpoint (required in worker mode).")
statusEndpoint = flag.String("status_endpoint", "", "Local status gRPC
endpoint (optional in worker mode).")
- semiPersistDir = flag.String("semi_persist_dir", "/tmp", "Local
semi-persistent directory (optional in worker mode).")
Review Comment:
This is getting passed in through the Boot Container, but that just means we
remove it in the boot container, and deprecated/remove the harness flag later.
https://github.com/apache/beam/blob/ff81afdc4adbd02b3686f01fce4160f11bb7246d/sdks/go/container/boot.go#L107
Issue Time Tracking
-------------------
Worklog Id: (was: 758631)
Time Spent: 1.5h (was: 1h 20m)
> Address Staticcheck warnings in the harness package
> ---------------------------------------------------
>
> Key: BEAM-14286
> URL: https://issues.apache.org/jira/browse/BEAM-14286
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Address non-deprecation staticcheck warnings in the harness package, largely
> focusing on unused fields and and variables.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
