[
https://issues.apache.org/jira/browse/BEAM-14215?focusedWorklogId=760079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760079
]
ASF GitHub Bot logged work on BEAM-14215:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 14:16
Start Date: 21/Apr/22 14:16
Worklog Time Spent: 10m
Work Description: sfc-gh-kbregula opened a new pull request, #17426:
URL: https://github.com/apache/beam/pull/17426
@reuvenlax commented that in some cases this change can cause regressions,
so I revert the change.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 760079)
Time Spent: 1.5h (was: 1h 20m)
> Incomplete argument validation in SnowflakeIO
> ---------------------------------------------
>
> Key: BEAM-14215
> URL: https://issues.apache.org/jira/browse/BEAM-14215
> Project: Beam
> Issue Type: Improvement
> Components: io-java-snowflake
> Reporter: Kamil Breguła (SF)
> Assignee: Kamil Breguła (SF)
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Hi.
> I noticed that the validation of arguments from users is not complete, which
> sometimes leads to problems that are difficult to troubleshoot:
> - The server name or address must be specified, but it is not checked.
> - We have validation for multiple arguments, but only checks if the builder
> method was called, but the value can still be empty as we use ValueProvider
> in multiple places.
> Best regards,
> Kamil
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
