[
https://issues.apache.org/jira/browse/BEAM-14346?focusedWorklogId=760096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760096
]
ASF GitHub Bot logged work on BEAM-14346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 14:31
Start Date: 21/Apr/22 14:31
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17425:
URL: https://github.com/apache/beam/pull/17425#issuecomment-1105296677
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17425](https://codecov.io/gh/apache/beam/pull/17425?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5489941) into
[master](https://codecov.io/gh/apache/beam/commit/e4d2050ccbaafb90428ab6c0cc494039f6282dae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e4d2050) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17425 +/- ##
=======================================
Coverage 73.83% 73.83%
=======================================
Files 686 686
Lines 90143 90143
=======================================
+ Hits 66555 66558 +3
+ Misses 22406 22401 -5
- Partials 1182 1184 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.56% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/runtime/exec/fn.go](https://codecov.io/gh/apache/beam/pull/17425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9mbi5nbw==)
| `56.53% <100.00%> (+0.98%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17425?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17425?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[e4d2050...5489941](https://codecov.io/gh/apache/beam/pull/17425?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 760096)
Time Spent: 40m (was: 0.5h)
> ret2() function checks incorrect index for error case
> -----------------------------------------------------
>
> Key: BEAM-14346
> URL: https://issues.apache.org/jira/browse/BEAM-14346
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P1
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The updated ret2() function is checking a non-existent index (2) for errors
> when it should be checking index 1.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
