[
https://issues.apache.org/jira/browse/BEAM-14326?focusedWorklogId=760143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760143
]
ASF GitHub Bot logged work on BEAM-14326:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 15:51
Start Date: 21/Apr/22 15:51
Worklog Time Spent: 10m
Work Description: reuvenlax commented on code in PR #17428:
URL: https://github.com/apache/beam/pull/17428#discussion_r855338653
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableSchemaCache.java:
##########
@@ -271,10 +280,11 @@ public void refreshThread() {
if (timeRemaining.getMillis() > 0) {
Thread.sleep(timeRemaining.getMillis());
}
- } catch (InterruptedException e) {
- runUnderMonitor(() -> this.stopped = true);
- return;
- } catch (IOException e) {
+ } catch (Exception e) {
Review Comment:
That is sorta what is happening - we still exit the function, but schedule
another closure. I'm not aware of any case where we want to shut down the
executor itself.
Issue Time Tracking
-------------------
Worklog Id: (was: 760143)
Time Spent: 50m (was: 40m)
> Pipelines using BigQueryIO connector with one of the Storage Write API
> methods don't exit the launch process
> ------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-14326
> URL: https://issues.apache.org/jira/browse/BEAM-14326
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Sergei Lilichenko
> Assignee: Reuven Lax
> Priority: P1
> Fix For: 2.39.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The pipeline starts, but the launch process doesn't exit.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
