[ 
https://issues.apache.org/jira/browse/BEAM-1754?focusedWorklogId=760481&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760481
 ]

ASF GitHub Bot logged work on BEAM-1754:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Apr/22 22:31
            Start Date: 21/Apr/22 22:31
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on code in PR #17341:
URL: https://github.com/apache/beam/pull/17341#discussion_r855639247


##########
sdks/typescript/test/core_test.ts:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as beam from "../src/apache_beam";
+import * as assert from "assert";
+import { BytesCoder } from "../src/apache_beam/coders/standard_coders";
+import { Pipeline } from "../src/apache_beam/internal/pipeline";
+// TODO(pabloem): Fix installation.
+
+describe("core module", function () {
+  describe("runs a basic impulse expansion", function () {
+    it("runs a basic Impulse expansion", function () {
+      var p = new Pipeline();
+      var res = new beam.Root(p).apply(new beam.Impulse());
+
+      assert.equal(res.type, "pcollection");
+      assert.deepEqual(p.context.getPCollectionCoder(res), new BytesCoder());
+    });
+    it("runs a ParDo expansion", function () {
+      var p = new Pipeline();
+      var res = new beam.Root(p)
+        .apply(new beam.Impulse())
+        .map(function (v: any) {
+          return v * 2;
+        });
+    });
+    it("runs a GroupBy expansion", function () {});

Review Comment:
   Removed.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 760481)
    Time Spent: 3h 10m  (was: 3h)

> Will Dataflow ever support Node.js with an SDK similar to Java or Python?
> -------------------------------------------------------------------------
>
>                 Key: BEAM-1754
>                 URL: https://issues.apache.org/jira/browse/BEAM-1754
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-ideas
>            Reporter: Diego Zuluaga
>            Assignee: Kerry Donny-Clark
>            Priority: P3
>              Labels: node.js
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> I like the philosophy behind DataFlow and found the Java and Python samples 
> highly comprehensible. However, I have to admit that for most Node.js 
> developers who have little background on typed languages and are used to get 
> up to speed with frameworks incredibly fast, learning Dataflow might take 
> some learning curve that they/we're not used to. So, I wonder if at any point 
> in time Dataflow will provide a Node.js SDK. Maybe this is out of the 
> question, but I wanted to run it by the team as it would be awesome to have 
> something along these lines!
> Thanks,
> Diego
> Question originaly posted in SO:
> http://stackoverflow.com/questions/42893436/will-dataflow-ever-support-node-js-with-and-sdk-similar-to-java-or-python



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to