[ 
https://issues.apache.org/jira/browse/BEAM-7075?focusedWorklogId=227550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227550
 ]

ASF GitHub Bot logged work on BEAM-7075:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Apr/19 09:28
            Start Date: 15/Apr/19 09:28
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on issue #8304: [BEAM-7075] Create 
Redis embedded server on @BeforeClass and simplify tests
URL: https://github.com/apache/beam/pull/8304#issuecomment-483178312
 
 
   Thanks JB, Clean up is not needed if we take care of using a different key 
or key prefix in each test, this PR does that. We could make it more robust by 
cleaning the data on `@After` with a minor performance cost in the future. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 227550)
    Time Spent: 40m  (was: 0.5h)

> RedisIOTest creates multiple instances of the embedded server
> -------------------------------------------------------------
>
>                 Key: BEAM-7075
>                 URL: https://issues.apache.org/jira/browse/BEAM-7075
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-redis
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> RedisIOTest manages an embedded server for test purposes but it is 
> instantiated on JUnit `@Before` instead of `@BeforeClass` as a consequence an 
> instance is created for every test, and an associated extra port is used too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to