[ 
https://issues.apache.org/jira/browse/BEAM-11105?focusedWorklogId=764526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764526
 ]

ASF GitHub Bot logged work on BEAM-11105:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Apr/22 22:18
            Start Date: 29/Apr/22 22:18
    Worklog Time Spent: 10m 
      Work Description: damccorm commented on code in PR #17476:
URL: https://github.com/apache/beam/pull/17476#discussion_r862211506


##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -96,3 +98,12 @@ type WatermarkEstimator interface {
        // splits or checkpoints to advance the output watermark of the 
restriction's stage.
        CurrentWatermark() time.Time
 }
+
+// ToWatermarkEstimator is an interface used to represent a user defined 
watermark estimator that
+// has the ability to observe timestamps of elements outputted from a ParDo's 
emit function.
+type ToWatermarkEstimator interface {

Review Comment:
   I ended up going with TimestampObservingEstimator





Issue Time Tracking
-------------------

    Worklog Id:     (was: 764526)
    Time Spent: 10h  (was: 9h 50m)

> [Go SDK] Watermark Estimation
> -----------------------------
>
>                 Key: BEAM-11105
>                 URL: https://issues.apache.org/jira/browse/BEAM-11105
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Danny McCormick
>            Priority: P3
>          Time Spent: 10h
>  Remaining Estimate: 0h
>
> Allow self checkpointing SplittableDoFns to specify a watermark estimator.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and 
> the programming guide updated with SDF content.)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to