[
https://issues.apache.org/jira/browse/BEAM-10265?focusedWorklogId=764554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764554
]
ASF GitHub Bot logged work on BEAM-10265:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/22 23:48
Start Date: 29/Apr/22 23:48
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on code in PR #17477:
URL: https://github.com/apache/beam/pull/17477#discussion_r862260115
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java:
##########
@@ -126,6 +127,7 @@
* </ul>
*/
@SuppressWarnings({
+ "nullness", // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Review Comment:
Could you address the null checker errors rather than suppressing it in this
way? The goal of BEAM-10402 is to reduce the number of these suppressions over
time :)
Issue Time Tracking
-------------------
Worklog Id: (was: 764554)
Time Spent: 4.5h (was: 4h 20m)
> GetterBasedSchemaProvider#schemaFor stack overflows when given a recursive
> schema
> ---------------------------------------------------------------------------------
>
> Key: BEAM-10265
> URL: https://issues.apache.org/jira/browse/BEAM-10265
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.21.0, 2.22.0
> Reporter: Reza ardeshir rokni
> Assignee: Andrei Gurau
> Priority: P3
> Labels: Clarified, starter
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Proto:
> message TSFoo {
> string a = 1;
> string b = 2;
> TSFoo theOlderMe = 3;
> }
> new ProtoMessageSchema().schemaFor(TypeDescriptor.of(Foo.TSFoo.class));
> Causes a stackoverflow.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
