[
https://issues.apache.org/jira/browse/BEAM-6993?focusedWorklogId=227678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227678
]
ASF GitHub Bot logged work on BEAM-6993:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/19 13:17
Start Date: 15/Apr/19 13:17
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #8303: [BEAM-6993]
Ignore missing artifacts dir during cleanup
URL: https://github.com/apache/beam/pull/8303#discussion_r275354936
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/BeamFileSystemArtifactStagingService.java
##########
@@ -165,7 +165,8 @@ public void removeArtifacts(String stagingSessionToken)
throws Exception {
ResourceId artifactsResourceId =
dir.resolve(ARTIFACTS, StandardResolveOptions.RESOLVE_DIRECTORY);
LOG.debug("Removing artifacts: {}", artifactsResourceId);
- FileSystems.delete(Collections.singletonList(artifactsResourceId));
+ FileSystems.delete(
+ Collections.singletonList(artifactsResourceId),
StandardMoveOptions.IGNORE_MISSING_FILES);
Review comment:
I don't think there is any potential for bugs here. The artifacts are
removed before attempting to delete the directory. If there was an issue then
it would surface when removing the artifact files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 227678)
Time Spent: 1.5h (was: 1h 20m)
> Default to cleaning staged artifacts after running portable pipeline
> --------------------------------------------------------------------
>
> Key: BEAM-6993
> URL: https://issues.apache.org/jira/browse/BEAM-6993
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability
> Fix For: 2.13.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The default is to accumulate staged artifacts of portable pipelines. I think
> we should change that to delete them after pipeline execution has finished.
> There is already configuration to override it.
> CC [~angoenka] [~thw]]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
