[ 
https://issues.apache.org/jira/browse/BEAM-11105?focusedWorklogId=765112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765112
 ]

ASF GitHub Bot logged work on BEAM-11105:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/22 19:22
            Start Date: 02/May/22 19:22
    Worklog Time Spent: 10m 
      Work Description: damccorm commented on code in PR #17522:
URL: https://github.com/apache/beam/pull/17522#discussion_r863118073


##########
sdks/go/examples/snippets/04transforms.go:
##########
@@ -105,6 +106,52 @@ func (fn *splittableDoFn) ProcessElement(element string, 
bf beam.BundleFinalizat
 
 // [END bundlefinalization_simplecallback]
 
+// [START watermarkestimation_customestimator]
+
+// (Optional) - define a custom watermark state type.

Review Comment:
   That's fine - we aren't particularly consistent on that with our docs 
though. Might be worth a pass to do that at some point. I updated to do this.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 765112)
    Time Spent: 13h 50m  (was: 13h 40m)

> [Go SDK] Watermark Estimation
> -----------------------------
>
>                 Key: BEAM-11105
>                 URL: https://issues.apache.org/jira/browse/BEAM-11105
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Danny McCormick
>            Priority: P3
>          Time Spent: 13h 50m
>  Remaining Estimate: 0h
>
> Allow self checkpointing SplittableDoFns to specify a watermark estimator.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and 
> the programming guide updated with SDF content.)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to