[
https://issues.apache.org/jira/browse/BEAM-14218?focusedWorklogId=765127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765127
]
ASF GitHub Bot logged work on BEAM-14218:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/22 20:52
Start Date: 02/May/22 20:52
Worklog Time Spent: 10m
Work Description: ryanthompson591 commented on code in PR #17448:
URL: https://github.com/apache/beam/pull/17448#discussion_r863181718
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -83,14 +84,29 @@ def get_inference_runner(self) -> InferenceRunner:
class RunInference(beam.PTransform):
- """An extensible transform for running inferences."""
- def __init__(self, model_loader: ModelLoader, clock=None):
+ """An extensible transform for running inferences.
+ Args:
+ model_loader: An implementation of InferenceRunner.
+ clock: A clock implementing get_current_time_in_microseconds.
+ close_to_resource: A string representing the resource location hints.
+ """
+ def __init__(self,
+ model_loader: ModelLoader,
+ clock:_Clock=None,
+ close_to_resource:str=None):
self._model_loader = model_loader
self._clock = clock
+ self._close_to_resource = close_to_resource
Review Comment:
That actually makes a lot of sense and I think it will work.
In the TFX-BSL implementation, the data does come from the input paramter
which the loader has access to.
https://github.com/tensorflow/tfx-bsl/blob/182918aaefd5287e7669d87bfc818155470315aa/tfx_bsl/beam/run_inference.py#L118
Issue Time Tracking
-------------------
Worklog Id: (was: 765127)
Time Spent: 1h 40m (was: 1.5h)
> Add resource location hints to base RunInference Implementation
> ---------------------------------------------------------------
>
> Key: BEAM-14218
> URL: https://issues.apache.org/jira/browse/BEAM-14218
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ryan Thompson
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Our generic version of RunInference should add resource location hints,
> similar to what TFX-BSL does here.
>
> [https://github.com/tensorflow/tfx-bsl/blob/182918aaefd5287e7669d87bfc818155470315aa/tfx_bsl/beam/run_inference.py#L117]
>
> There's no reason that these hints shouldn't be just as relevant to sk-learn
> or pytorch large models hosted on GC or wherever these hints are supported.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
