[ 
https://issues.apache.org/jira/browse/BEAM-14314?focusedWorklogId=765128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765128
 ]

ASF GitHub Bot logged work on BEAM-14314:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/22 20:53
            Start Date: 02/May/22 20:53
    Worklog Time Spent: 10m 
      Work Description: Abacn commented on code in PR #17380:
URL: https://github.com/apache/beam/pull/17380#discussion_r863182185


##########
sdks/python/apache_beam/io/aws/s3io.py:
##########
@@ -464,6 +459,49 @@ def exists(self, path):
         # We re-raise all other exceptions
         raise
 
+  def _status(self, path):

Review Comment:
   This function is also used by FileSystem.metadata implementations, in order 
to obtain both file size and last updated fields at once (one request in web 
filesystems). If the file size and last_updated is collected separately it 
would double the api request for filesystem._list (used by match) and 
regression may be introduced.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 765128)
    Time Spent: 3h 50m  (was: 3h 40m)

> Add last_updated field in filesystem.FileMetaData
> -------------------------------------------------
>
>                 Key: BEAM-14314
>                 URL: https://issues.apache.org/jira/browse/BEAM-14314
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-py-common
>            Reporter: Yi Hu
>            Assignee: Yi Hu
>            Priority: P2
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> This will be the python counterpart of BEAM-5910
> Per python naming convention, the field will be named as 
> "last_updated_in_seconds".



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to