[ 
https://issues.apache.org/jira/browse/BEAM-14250?focusedWorklogId=765251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765251
 ]

ASF GitHub Bot logged work on BEAM-14250:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/May/22 00:56
            Start Date: 03/May/22 00:56
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on PR #17531:
URL: https://github.com/apache/beam/pull/17531#issuecomment-1115512295

   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/17531?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#17531](https://codecov.io/gh/apache/beam/pull/17531?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (0f73bb4) into 
[master](https://codecov.io/gh/apache/beam/commit/40673dc84c91a50fea3aac2e0d03c9bfb0deddec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (40673dc) will **increase** coverage by `0.04%`.
   > The diff coverage is `10.00%`.
   
   > :exclamation: Current head 0f73bb4 differs from pull request most recent 
head 639225e. Consider uploading reports for the commit 639225e to get more 
accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #17531      +/-   ##
   ==========================================
   + Coverage   73.81%   73.85%   +0.04%     
   ==========================================
     Files         690      690              
     Lines       90944    91039      +95     
   ==========================================
   + Hits        67129    67236     +107     
   + Misses      22595    22583      -12     
     Partials     1220     1220              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.69% <10.00%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/17531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=)
 | `87.95% <0.00%> (-4.46%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==)
 | `94.23% <25.00%> (-2.77%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
 | `90.24% <0.00%> (-4.88%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/gcp/gcsfilesystem.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2ZpbGVzeXN0ZW0ucHk=)
 | `88.23% <0.00%> (-1.77%)` | :arrow_down: |
   | 
[.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
 | `96.72% <0.00%> (-1.64%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=)
 | `89.54% <0.00%> (-0.83%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/filesystem.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbS5weQ==)
 | `88.76% <0.00%> (-0.65%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5)
 | `90.97% <0.00%> (-0.50%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/gcp/gcsio.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2djc2lvLnB5)
 | `92.26% <0.00%> (-0.36%)` | :arrow_down: |
   | 
[...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==)
 | `90.18% <0.00%> (-0.31%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/beam/pull/17531/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/17531?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/17531?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[40673dc...639225e](https://codecov.io/gh/apache/beam/pull/17531?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 765251)
    Time Spent: 2h  (was: 1h 50m)

> Coder registration doesn't work for types in main module.
> ---------------------------------------------------------
>
>                 Key: BEAM-14250
>                 URL: https://issues.apache.org/jira/browse/BEAM-14250
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: P2
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> This is because type equality is not preserved through pickling. (Similarly 
> for any other dynamic types that can't be pickled by reference.)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to